Project

General

Profile

Enhancement #187

improve analog.c

Added by Jason knichel over 8 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
Library
Target version:
Start date:
Due date:
% Done:

0%


Description

this applies to code/lib/src/libdragonfly/analog.c

-indentation uses hard tabs instead of the specified number of soft tabs
-where the { braces are is inconsistent (sometimes they are on the same line as the function, sometimes they are on their own line)
-analog_get8 and analog_get10 share a lot of code. That shared code could be extracted into its own function
-the ISR contains commented out debugging code that could be removed if you think it is fully tested
-fix the TODO comments I added to the file

History

#1 Updated by Kevin Woo over 8 years ago

Check if the loop runs through all the analog ports.

#4 Updated by Rich Hong over 7 years ago

  • Status changed from 5 to Fixed

#5 Updated by Rich Hong over 7 years ago

  • Category set to Library

Also available in: Atom PDF