Enhancement #195

improve lights.c

Added by Jason knichel almost 7 years ago. Updated about 4 years ago.

Status:FixedStart date:
Priority:NormalDue date:
Assignee:Martin Herrmann% Done:

100%

Category:Library
Target version:Library

Description

-address the TODO statements I placed in the file
-identation is the wrong amount
-some places use hard tabs instead of soft tabs
-I see that someone has some "DOES THIS WORK" comments in the file already... maybe those should be addressed

History

#1 Updated by Kevin Woo almost 7 years ago

Need to redo the timing for all the colors
The pwm loop is horrible according to Cornell. Need to rewrite it again.

#2 Updated by Brad Neuman about 6 years ago

In the interrupt check if the compare is below a certain threshold for OFF and if so, don't turn in on in the overflow interrupt, so it doesn't flicker

#3 Updated by Kevin Woo almost 6 years ago

Bug with rtc and orbs blowing away settings.timer 3 is the problem.

#4 Updated by Kevin Woo over 5 years ago

  • Status changed from New to Assigned

#5 Updated by Rich Hong over 5 years ago

  • Category set to Library

#6 Updated by Martin Herrmann over 5 years ago

  • Assignee changed from Kevin Woo to Martin Herrmann

#7 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 0 to 10

#8 Updated by Kevin Woo over 5 years ago

  • Priority changed from High to Normal

#9 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 10 to 20

#10 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 20 to 40

#11 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 40 to 50

#12 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 50 to 60

#13 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 60 to 70

#14 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 70 to 80

#15 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 80 to 90

#16 Updated by Martin Herrmann over 5 years ago

  • % Done changed from 90 to 100

Maximum CPU usage: <0.8%
Longest synchronized block: 30us

#17 Updated by Martin Herrmann over 5 years ago

Martin Herrmann wrote:
  • Maximum CPU usage: <0.8%
  • Longest synchronized block: 30us
Work left to do:
  • Merge the branch into the trunk
  • Check the Doxygen documentation

#18 Updated by Alex Zirbel about 4 years ago

  • Status changed from Assigned to Fixed

Also available in: Atom PDF