Enhancement #187

improve analog.c

Added by Jason knichel over 6 years ago. Updated about 5 years ago.

Status:FixedStart date:
Priority:NormalDue date:
Assignee:Kevin Woo% Done:

0%

Category:Library
Target version:Library

Description

this applies to code/lib/src/libdragonfly/analog.c

-indentation uses hard tabs instead of the specified number of soft tabs
-where the { braces are is inconsistent (sometimes they are on the same line as the function, sometimes they are on their own line)
-analog_get8 and analog_get10 share a lot of code. That shared code could be extracted into its own function
-the ISR contains commented out debugging code that could be removed if you think it is fully tested
-fix the TODO comments I added to the file

History

#1 Updated by Kevin Woo about 6 years ago

Check if the loop runs through all the analog ports.

#2 Updated by Kevin Woo about 6 years ago

  • 6 set to fixed

#3 Updated by Kevin Woo about 5 years ago

  • 2 set to Fixed

#4 Updated by Rich Hong about 5 years ago

  • Status changed from 5 to Fixed

#5 Updated by Rich Hong about 5 years ago

  • Category set to Library

Also available in: Atom PDF